Avoid useless host automa lookup (#1724)
The host automa is used for two tasks: * protocol sub-classification (obviously); * DGA evaluation: the idea is that if a domain is present in this automa, it can't be a DGA, regardless of its format/name. In most dissectors both checks are executed, i.e. the code is something like: ``` ndpi_match_host_subprotocol(..., flow->host_server_name, ...); ndpi_check_dga_name(..., flow->host_server_name,...); ``` In that common case, we can perform only one automa lookup: if we check the sub-classification before the DGA, we can avoid the second lookup in the DGA function itself.
This commit is contained in:
@@ -4330,12 +4330,12 @@ static void dgaUnitTest() {
|
||||
|
||||
for(i=0; non_dga[i] != NULL; i++) {
|
||||
if(debug) printf("Checking non DGA %s\n", non_dga[i]);
|
||||
assert(ndpi_check_dga_name(ndpi_str, NULL, (char*)non_dga[i], 1) == 0);
|
||||
assert(ndpi_check_dga_name(ndpi_str, NULL, (char*)non_dga[i], 1, 1) == 0);
|
||||
}
|
||||
|
||||
for(i=0; dga[i] != NULL; i++) {
|
||||
if(debug) printf("Checking DGA %s\n", non_dga[i]);
|
||||
assert(ndpi_check_dga_name(ndpi_str, NULL, (char*)dga[i], 1) == 1);
|
||||
assert(ndpi_check_dga_name(ndpi_str, NULL, (char*)dga[i], 1, 1) == 1);
|
||||
}
|
||||
|
||||
ndpi_exit_detection_module(ndpi_str);
|
||||
|
||||
Reference in New Issue
Block a user