TINC: avoid processing SYN packets (#1676)
Sincee6b332aa, we have proper support for detecting client/server direction. So Tinc dissector is now able to properly initialize the cache entry only when needed and not anymore at the SYN time; initializing that entry for **every** SYN packets was a complete waste of resources. Since4896dabb, the various `struct ndpi_call_function_struct` structures are not more separate objects and therefore comparing them using only their pointers is bogus: this bug was triggered by this change because `ndpi_str->callback_buffer_size_tcp_no_payload` is now 0.
This commit is contained in:
@@ -556,11 +556,6 @@ struct ndpi_flow_input_info {
|
||||
/* ******************* ********************* ****************** */
|
||||
/* ************************************************************ */
|
||||
|
||||
PACK_ON struct tinc_cache_entry {
|
||||
u_int32_t src_address;
|
||||
u_int32_t dst_address;
|
||||
u_int16_t dst_port;
|
||||
} PACK_OFF;
|
||||
//CFFI.NDPI_PACKED_STRUCTURES
|
||||
#endif // NDPI_CFFI_PREPROCESSING_EXCLUDE_PACKED
|
||||
|
||||
@@ -1458,7 +1453,6 @@ struct ndpi_flow_struct {
|
||||
|
||||
/* NDPI_PROTOCOL_TINC */
|
||||
u_int8_t tinc_state;
|
||||
struct tinc_cache_entry tinc_cache_entry;
|
||||
|
||||
/*
|
||||
Leave this field below at the end
|
||||
|
||||
Reference in New Issue
Block a user