HTTP: correctly set the classification protocols
Classification should always be set via `ndpi_set_detected_protocol()` to be sure to set a correct `confidence` value, too. Having a "known" protocol stack with `NDPI_CONFIDENCE_UNKNOWN` as confidence, is not valid. This code in HTTP dissector likely needs some more thoughts (the classification itself of the attached example doesn't make a lot of sense), but the goal of this commit is only to always have a valid `confidence` value.
This commit is contained in:
@@ -762,8 +762,7 @@ static void check_content_type_and_change_protocol(struct ndpi_detection_module_
|
||||
if(ndpi_struct->proto_defaults[flow->guessed_protocol_id].subprotocol_count == 0) {
|
||||
if(flow->detected_protocol_stack[0] == NDPI_PROTOCOL_UNKNOWN &&
|
||||
flow->guessed_host_protocol_id != NDPI_PROTOCOL_UNKNOWN) {
|
||||
flow->detected_protocol_stack[0] = flow->guessed_host_protocol_id;
|
||||
flow->detected_protocol_stack[1] = flow->guessed_protocol_id;
|
||||
ndpi_set_detected_protocol(ndpi_struct, flow, flow->guessed_host_protocol_id, flow->guessed_protocol_id, NDPI_CONFIDENCE_DPI);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user