From 2636c07571ecc19f832c81b71544a0ef2a69a3a6 Mon Sep 17 00:00:00 2001 From: Nardi Ivan Date: Mon, 10 Jan 2022 10:27:16 +0100 Subject: [PATCH] MONGODB: avoid false positives --- src/lib/protocols/mongodb.c | 21 ++++++++++++++++++- tests/pcap/mongo_false_positive.pcapng | Bin 0 -> 13464 bytes tests/result/mongo_false_positive.pcapng.out | 8 +++++++ 3 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 tests/pcap/mongo_false_positive.pcapng create mode 100644 tests/result/mongo_false_positive.pcapng.out diff --git a/src/lib/protocols/mongodb.c b/src/lib/protocols/mongodb.c index 5b462cda2..1f09efd63 100644 --- a/src/lib/protocols/mongodb.c +++ b/src/lib/protocols/mongodb.c @@ -26,6 +26,8 @@ #include "ndpi_api.h" +/* https://docs.mongodb.com/manual/reference/mongodb-wire-protocol/ */ + enum mongo_opcodes { OP_REPLY = 1, @@ -67,6 +69,7 @@ static void ndpi_check_mongodb(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) { struct mongo_message_header mongodb_hdr; struct ndpi_packet_struct *packet = &ndpi_struct->packet; + uint32_t responseFlags; if (packet->payload_packet_len <= sizeof(mongodb_hdr)) { NDPI_EXCLUDE_PROTO(ndpi_struct, flow); @@ -87,7 +90,6 @@ static void ndpi_check_mongodb(struct ndpi_detection_module_struct *ndpi_struct, } switch(le32toh(mongodb_hdr.op_code)) { - case OP_REPLY: case OP_UPDATE: case OP_INSERT: case RESERVED: @@ -98,6 +100,23 @@ static void ndpi_check_mongodb(struct ndpi_detection_module_struct *ndpi_struct, case OP_MSG: set_mongodb_detected(ndpi_struct, flow); break; + case OP_REPLY: + /* struct { + MsgHeader header; // standard message header + int32 responseFlags; // bit vector - see details below + int64 cursorID; // cursor id if client needs to do get more's + int32 startingFrom; // where in the cursor this reply is starting + int32 numberReturned; // number of documents in the reply + document* documents; // documents + } + */ + if(packet->payload_packet_len > sizeof(mongodb_hdr) + 20) { + responseFlags = le32toh(*(uint32_t *)(packet->payload + sizeof(mongodb_hdr))); + if((responseFlags & 0xFFFFFFF0) == 0) + set_mongodb_detected(ndpi_struct, flow); + } + break; + default: NDPI_LOG_DBG(ndpi_struct, "Invalid MONGODB length"); NDPI_EXCLUDE_PROTO(ndpi_struct, flow); diff --git a/tests/pcap/mongo_false_positive.pcapng b/tests/pcap/mongo_false_positive.pcapng new file mode 100644 index 0000000000000000000000000000000000000000..44aa700f28d185c7514e57f4ee286fc9d5944bd5 GIT binary patch literal 13464 zcmd6uWmKF=*RH#9cZURb4ek=$odkDxcbDMq1a~KBAXtLC6Fj(w0KxUp^D^^J=FIo4 zGr#8SwQ6-&H(fXTsk^V*R6W2UBEl&E003EDT0G#>^h`0gXZR{P_3?0Du7?0LD&c zOt4SyKs~(<3efwY=XRjZQ)rYz0tCbR;$A;J2es#b1mqKu!2m=709JBcL4YsR5q+!l zM~vG>H=@rWz)#(Vlb=98=?6vxKv;TGf`C*2f`h{Vfe>K-(fxfOkj`KAGGGV)7d-$# z5Wozj7X{J+X#zie4l&Wh#Cg(e^+S7n{BZG`Uj36E6iDsw^$;Nb^BaKjOV%HZTLlLI zKp&=m(3>k4$1-J3YEUIqi zC)cWRJ*VB^Xu5~p#YBJNI@hW#at?)(lwh44H()hIbqdicTgNy~>xa z>}Ab_wyFacS`=YS5g*QPW?Qa!_+hfE^+(PDfn}Q%PGB;y)_5 z@zfNqiA2s074OohvammhxzE|Ia^79TvkT!>(<;r7LF<=qtCeZ2VF`YnA_h1CGxb3;B>3v8JrNMgF zZhY4|tkZN6GeSd0Cef~6D{7)!&`@xyeJNmYEC_Q~hv?Djf`+mwYNqDbGnKV6sODFE zamCT9GA161YN?i)<5Uo>ffP*{9u7`U#dhS+ED*_z*0J2qw+iFb#76N!-Vz1d0%k?E zgtzR=WG1>Fam}E7Yx5ZIS5&>Q94-A9Z_CB*>e4o8_C)EESBhlU`(91szPO_b<5)$K z!Ae|SEidxrKUz58nC|jtV3qjV@%@83q^;19nhKm@z#;eHdZIOYd z#)K~u=M%~jls@0X<2}DG?i}K75_4d}h@vtt|LM^x^;;wpMd>JQ%@Xmzoyszsx-E6K z^9&z5Ec?(3c_aN83gQH?cyCW=_FH9KLzAvQr~^yMmECZv{r`Z5;(j( zJ}LQNtW$^+_J)MnAQ*`Z2E9fYrt~(BN56G^OukzOne;g7YmrchMaauYsWKQN z9y`BIA#O!@^Y3NSwVU)m_A02{ck$wg z@1!h4<*4&uY<7Dw=-2rLRllTIqfDt&MKO1^OSI}~o4N|8Vc=P{KBF2;H8j_Ol@(~D z8@kA{XUr1ic61l&T3uK8*UezElcN> z2?67>2=Pl2=7J_$290Ih_5^x=KYO6QuiD{b0TWrVsGg1xe8Wec198SO)sLbR#tL>y zF-51kN0y48i9ew`i}4#6O_9(yjCj&P+P!`?1?!9{$XB@J?Lh*wO5@L{@iPzMi)4j& z?AR%mpDt4z=1%OvHG0_pwD`NP!Q46-0fx$JncI zD|hI`)r(2TQb$_;#emiDq-)z%Hrv7uVaAsYb?O#$Cv6?!tg*L@-C?Nem z=L*UZlq&)x=$-#?{Z!&p{OZ#+0JZ1%BUgw?nk5kTHqn0N-mJ+J_i~=N2Y%J_oGT27 zdl3KSUMMlpI8=!~F_q+JacY4mw6gdf`R9CwJ{_Uc4H;X7k{=wx7x6}k!WdpdV0{wZo7c{5zVR zOE1^TFi`-0Elp+Ww%;T)c0T9`d-M|)wRHvg4WmIm=3a?{>A+Kz+%wZz{RokGscQ@D zat)IEfNYaPU{W8ETSwY_!w|3IHJ*2jOmX4R(CzQm%eUrv8YX93x4Pd8euwT7Q&9^> z?I3+?CD)S~Bp(S!f3p3)t>#X-vT9XWl9OCDE4hEyygooc-Gr)j<@7=36$)%C%WzC( zDDs|gkoqD6t^$1VwF9buRYHvaPLQ!+X@<_{5b4c_sr8j6Ebq)ZdT(Qrmml$fDv zv7@$}oAs5XyWi?QQV(sNL@@?2@@Vj`xK=h?0m9p-B1xzRSM3cPj5{Y5Dlidd=@%BEm zVlkHkeYDsCn&>@}HB`kuM{+H|WYP%Tuet>njM?7zFeQ?qrLVVc_I@g<7giJZRhqdE zp1eoys8%ROvX+A9JlpcnY2aAVEbF&dIQmyuu+dO(A2hpLwDlQwSID>%jz|3gof|^l z;tv^u8Jba2>nD8~saA=8=)wK%(6mR=0@XFq?L%a(@LcKV3!fHYPVOw@peMC`dK9b7 z93%KU$#bk?2GtXZ#)V`%>uU%UdvX*X1z6E-%5e1d?Gb7fQPybEWs`~4{fVu9?i?!C zH^ZUHjfA<9#0~lYqwP4r#GOlXur1Ozs;0RiYo{=iB&A`Ms7&5Z*;Vf$MXm9BOWPGm zO2xE7LvA)Qnzf2|CT+b)>vy;yG_|S>3CD2Dd96ic;Fk(C1VT*S@1I*{-dx}m!BM)D zBPh<<>|a^r8Fm)$U?-G=X?jdJ$?!Dimn#gY#W{|^oZ<-5E7YaKDB#W(dDv2t41~XI ziE5vF%|BK@Da#ei(7OGyH9TW{Gs@)E8h8&}L-G%#f)D8_N_>W1A|HTMYr zh;-^aEZ+6R=XIT^ra1a{*ndo(mUo2EH<%G9{g=7_#K6CD|DeAu{vUHcr`vE51;l+n z_1{?t;^?2bf7jexfvKj?t`b(FOOMJqSHsxiAHWw}suXuU9K~o<4X%|zs@!owP$cc@ zAd&aAH_w0H-v}%`Wf@YmDJY}a2ZOAlZU9~xePVIXuN-&s{bqLX?oO2o25wS{n@%k% zP4#YEqcH0M~&>AO75|{8l*SidzAnva*{L1}B6cbG>N)Y$E zI-YZd{lDwo8K(*r#WslHbbERliFG9oRXpE}NPn;-87*}O#-!wmD{~ykxBJyq%sAG# z=pC_*HyrdV{J@+SL#NO_1=i*L`p&JJ#8kRA5+9M*m5N>+$>%5pudhvz?N_ikKv<}8 z+?LQV3fx!L=h&6E_sDGIuEZ=N;lIIDJD@AV5lOvQIjTLe`Ql6hlU1jW8Vr29WtFx; zN7%pXj1)s^7!mvtqBmhH$gECqfdJ;dB zrl`_XG?-llNx&-qg!43hMeHzKP{RNy)^j{xW9Wq{G2wcUKl)>mqSgtx(9W|qvaXx}*IwRo0& zTyn?mS19;FYfPab5yIji#I<1^eA@TjxY$xEsWuc& zXTbsV%PsoxD>H+4^1Bg7V-$ui$U$n4aC-X-bC~*vO6g;Ktxf3fYPul1X*oJ;T`v`D zZOgr54_ElL{T1*eW8}piM-g>C=cQ~J%4_C2c(>;TvVULeb*sdc&J-jQY(*vv?M6HR zbK=i9_p8z5j%JApvvFEZPm8NyM;RC#c0?_~5~`Vx<40^5E%o8zJ^k)$b=CPra_iP{ zWP=dCxQCD6=inGs z+hV8Tn$@0^pHfBHOmR&q0Cwp{v##{}j?xQXD{vx{|7Gs|O})#MmyqyJxrasBZMf0` z;$HUp?=1K$_jt$i5}WLZwQaSDP{bUWYnX=Ii*dbjDMSTY#CKb^lzw7--Y#?{C+G*K zY|X=^*dW628ai_(7YW{;k?Zi>5#qk-3uPcNYY3)eG2euL*$>9;+Nk9d7O(=FNKiIt zwN?0SRt4la|NfmX1mrZD9W6A6QJhY)WJb|>JfF)AAvc$Ud3>8~ZlkT&uAMQ+ zDUn59U)`@RuBaFMAQ46^$!o+q^!9DSP?D_5d;ra^GqK?h`)BJa=pBUhi) z;#m?`ull;JQwP_kmHXgJro*pB#}-Ij+<=A;mzcv6cjlJwa$xG=zx*JWiiQE!y}k~+ zx}kT)xz}!9OqpLzR}bZhe@*J!%a(N|nD)3wUB<|iox%80xxO6s$Xm%$E!6vCy=%JTUxo{-~&if3Yrqgl4L0gBMkx1l?o_(n}3>kJlw$QsdX7&WDO~R=NLz0Lz zjU_?}?15q^f!ii(lFRtFRz7;@Va#~nOOsHk#^v|pU9wv2W!l)8)&0`iW^N5TFknuFekKt7;RhelTWsIg8%r(f;?^9*zynDH zo(mBonUc1jLfRrTz)G`H^C2KdY6oRqY(TeX#Sk!6waxXlbV#Y5YqT{>do7;Unrb*z z>GQ~xaOr|KiF-f1;D%BCS-@FjgY~^=>UE{=ZF9rjY%_Z1hnBauVvwu(9tPGLUL)8^ z_k)Saxps2ptAdba;Uy_}>^Y4ztrLXzw`X7d&T*%+HL1AXc}1-;vZa-9ZcXg&tRZ7i zEoHwd8S$g;lFoW3dQ>)JiA`Y6f&O6vig_#J=Sv@Siz%L#k@}<$^w%Wu6frOFZ(VH_ z!b5jz1Dq&FG7i4D`|hI}>GE+5=POg^HIt%+`#JHS2=qy5m2?-oo3!)!Z-CQ?T&gA) z99oSsZfMhpxwA+0K=jCl)L)k1*_r&iTm&)Vuk~O&6kXy!=3-U1;d&5=i%D6(v*NE@ zydaVrcEbvKB&vrGT1r3nfi+Gk$&c{s53h*{p3pW>ICSe)PMMpq#^J2Yo;ybrBy zN#j8pq>wBkpI4XEEXdlhJBe<#yTSqo~8{+dLp`Zlr^Q?dy zuy?3b?IkZzv~PaAnt`#%YetvdeVADAs}=f7m--dc%wnS1YK(nl!3= zP|Gq;;hTZ;pp?yvT$IGEs(%ejS3Bl)VX;K)9@(I!DHo=`Bv_8|BKH=1*B_JL+SzW( z_GbA71nk2#;b(|bmc^-|W!;>gKR)w(oR;p@AVb*BYgKs2fR|}`g{0qlxc|NY84Bi1 z9P5l@SS72XvnNV4*}5_WS?lmIp(fN$#`udXUEhe%=Kl9MLu==EobV49pDFEM(A@Rq z_IcqAyB$zzC8FAjUkMp17NFw>($!Binom+ss19rJyI_TKL2JRBL#4C6?ecNj3iyD5 zUc>mgXA7sY_=@tiD!3cbsEFG;I`Djvwn9ag`Glc;-c(LnfcV352G`vca$3)VK#E2tB}+`(@Lxp>uGnr5_~O2RR`+%`R?Q5tCMJ> zi$j_0$gy5&OHMA2?@epqweidC2eyW2`k?=K@4j z@QevQ0hJ~vjHpR|7#gxuq1D81Z_3p0t`Dyp=b&sL3&yEdA38eC)~-_bS~(3I@jP|sK;+t8A~VXM%z4|{$y8k z^ixB!H}|IUqbb9*_Fq;m0ZccpQGFv_DTs<~Wtm*7E94tAzE;C;wz1l$ei`=3$&rF; ztA^wAhc@V8^K$rR*pU1da+Yi3IIi)_dTIVUwH@zt*IhhpaFP;Ic-ctkq>L+TKK8X{ zL3jn42~-rc#hB5D58e1_P^NFZXl;e5O8(A@zjBeceC?7Sj#axB9$NFj_dRZVkDb9P{sm`O%ywpv zZe{Y@rJY>3XhCDOSc<|PD1>#WEF>Pi{89_Ck?r(L;znpRt|HSyy$BmEgb#s=l^Y_} z{Ej%M;%#>wkHk1V;z`o(_`HeodpQZ0q{djo61Tqp6Bo7qv_E=T|00R$sSj$;@yGrs zBncZUh>PA^NL7z_e0W6g8`mY7$2CVRyhCp;lixud z-RxeKj$Y6F{Q4@bX4j_8qQYFJ3~&FTh@gE010Q1@{?@fh0hN;^AsL+#5xR-#XK^XR zfH_9rS05$kN~-<_8QR2_r4us47kcYZCgd5fTxOcSu^_g;3FyRS{5g0Bw;l0dbE(3U z?x}efgBfcZl${Qr&%+3Y9&ZJ+|K%>%0YOH@NS14IZelk7Mlld=8T+h;K`S2Fcd*%# zD!C)APw1U!VdeOkg2KpK$K?hjR-b_(XN#)Etu2XH+_M7udxzsX&Au?=kW$OX0SjK$ z^S6A%D!}jtb3~_gj}Z?0V%yr%hA??zKvNdtMzF9vhTXbyl^Lh&S~_2c{|m^vQv3Iu z5B&Q<`Xm5_^cuxHeK33T)fh5jh9vOlGo;~G zagoQinsDBLa>?|zV_I4pe4$$%RMCKsz0@!O5A?p5c)*VnE{Xd<&;4dk+}N}Xjqg9C zPbqabSmuHY8Q19xUiEO&zYZH6h;!-bH8DIeGoPt>>?z_9Nc@hx*WIonAL8DqX>w8= zmK>*S5TqRa&|NWaig*wZa4~uyjlCzSI~hdKem(E(+2=c25tYYL>y)gTMW~g$7IqLQ zx};Lx!uFz2xl{xTt9e9kZf|cdEF6A)m8y+<@)O;64*bBvufB}amH65Yi-qDMEtLe%MZEjh92eu_c4po6POI2kWY{mCj@-1l#PU^WnNikj;^PAx=80@ip^8 z3_e!VKxDL3Sr$*W9eoLkWT-hZG1L#8Tu)xr4U}4$d%A~=2#X3dEm|USh6r}rqXe}> zY-WO&KZ^5&nZ^!K)y;{1lr2(!lsfJI_iVMk{;Tnw3^wlC8A|eNA|gp2Kw_ z?e9#O!3sZLm^85tg`++cPX1CmQ;0m&w@~2wr>-vFFl$+GbZ&iI63?8jfvkkOcS8e6 zG!fL^gX9m?oamy-O4B3(UaMnmCnk{?$b%ik0i`Bvb%eaGs_B{ZEcGl!OA15pYHEWP zLar2;W^HGXkX%WZzC(WcF8`_DG&TBR22D?1i6kj)8))&U=sPQSt93&~`T3EBM@G_G zb`$Kf%w@fhzx`=@vr51%m5PX5rT|u`^ibk^=H1JImuh021Q?CR_}p+)B&PGunEQm= zCO*l#p=Nyn=&!va)9M>uDuJ;%GnH|7*oiq3yJADwxL_pdAIq6%Z%&A@HMD4x8Mw-j zhj!j_pc~NfC@8Vzp}7XL#w}3tH(Wqr(W!IrGrW zdm#Lj-f3jsMN6ui6vphU=_hV)BZ@UxdWo7HhWE*)6#L&@M?g&dYkfV*N|f|Z>uc=R zZo>l!&^j_%_B&faT>kTZtB7>VFZ-?STksnm6LF-oVV#6Qb@hpwFZy%$$-ixkwRemR zRG%kxym8r9&C7RC8N)?_ZP?}w)<~5PiBLngGu6hMg}i*!wytWv#Mcn)w-{#&5Mz+H?G|j)3Q}BZJnF1>|4X zkpl@6O&np+I^xavoGa3A^|j3(>qxLYkVSy z2ey&mX_YT)9AFPAc@(D^B`~t_{`#P2WJB_6)&^>&f&8t{FF4|27GnDSt zL|x|or(-wQeNrO#ycZz@g%OxnFFU4aPR%{c&J_eB#? z(#Iv0sPB8kn%PRL3;x{OxwEUUYvi#Ev=fNJ-^)T*ph7Uwd?Rd#1|=cvuN!}jN1j>R ziyc)%YELK;|8a$01DRu^SCJ83KLtbR668d^H|aaSG<77dcX$jMq4VW7bfo&xFuFYhjLaZ0y0(N+AmU z%+m2cbe;Ty9SkcPottH0;whDBWXS1rwllStJ2iF$Jebk~>Hi(aT0yvZ3J}MXzZoUP zKJ`KEIsV`nFo2!sw|xTeUpaR4<%wg1PaFeO7(VBU4B{A2?hlUnD*_2gaVhvW>Sy;F zyIXem4k!IztPjE0W-iO3Xk(Esj4jYMLLebT70Ch$B{~bY` zSjH2#x%L(xhP=(8SCdRBN%D0Wl<~QF_5ExT-wlr)O~J0iI+OG|upKywfBhopQModP ziNf-{UB7~7_^?82i)VK5)JX6Wtf+0FnyW}|pDdo{BlhmG?;(xrU31QgX9Ww5cSk9A z6h0G#Y_$l0Cla}>M1iIylA?44WrJTBersqmg~oBjr1s+(Ijn+&2mbxP>r>F2{ne-X zI;Q{Jr-R*w#{?jsM&wQZL7!RO<7X9^*&iU2NI=X$%xo=Cyv zP|LQP8gv}28a0MnhKh?ibS+4J018z%6)NUz2CLgo3=2{n?dF1&P|`O>(FR01G%J|s zdLuQVSnu_Y>uO@b%@2CTs)>4YZqTQ;zq)^1h4%sJ|D8|YKYJ47(}^S7B)g|Rs6EGj zeQLm-0P^YLU-tQr2~0F`6+u3g&v?!iJLJF5ddaPW!Tz@ol<*#q|dEn=KE)By1j-IiAkorz4vQo^hd=rFu-zy+Xer*UZ{|+VN=~`Y<^wI~AsndsPD^L)>Gm&O(JgY#g`hvi z+w9YuNR!ouYS$wtUe1IEB=CaKda>3|f9A?Zj5@EMC4?E(h6QweD0;&Izz!n4kW-qv zciE6Rd8!cp&HJlBbMjXoURXQ)V;|xwb{n3kfqclY{QKO1=Jn4$%>8nv?IffUC42LM z@~EY(Z!Gom;)=i1X_Cw?YAGs}Jl#?G#5Q$ zHAW^0!u}mMp%dUL+EKNQYqvF*^ab73H9V23Q505p{y{6%IpW+iQV^^b+_auRD+CAkaX?#3d+!$akkB!ssb=lOqj*MS z*Vkg^>pNJhDNG|6BpF%DBcQuFUF9wHrq{f$zVVJvtq0QlHnSYTK{y;IR+7u6#LW% zwdeT5cMt&_*dX7{QU2xq zraSs5M;SZ4c-*Mpke?@*BGk!rzXjR*Tk={h#gSe$_M{22+ze-uLP>>(*a%AxgQV^w zU0=tY+tx@E*l46&_67(@Xaw>1b#q&}JiBl_(15h&1AEx>uRK(h5rlnb5Sp&FKPjaY z;QbBo#b8=jTgSS+#BPJY#_QD7aOyWSF0?;wl=2kzx{)xtPk5d3w>?Y}AWBR(C^6n| zEvF?1AX3ft7^r zD4vCpmxFwW`z8-9XDD=|Y1e?9@E+X`{xuBa%hi~o>G}pf<9wr>2Ly!j`7@M>vJ_RH zpoB#G83_xa`tOR&A~ESEMK}BfL=SJMW1yg-b~HXGj--|gofn;h>88GwGZ4!S?Tc8ow z6RVt=XVGxc+@+I+uK8k=eLoaNSz#J)t}zJy^L=2;jCRDbb|lM74wm6m+4o*yZiF))IAYwmSD(r7VMdaay$uk}6e{xkd6o|_V@Kq!{eE5K#e_%9G=deWa zqMApDB9PmXsglhajyl8&UUIJ5PIR9!MM`h$aG#0#-{mxjS%2j;ASm=7a~e;#+wfum z#A(02XHNfiKggds?dJOHxvPg5#NH~bY-7;g3TMH!!U-iRWlN6{CbpD}G1A?(lQhi5 zh<4HVj)D9zQ)lZ6dJ#`kTNTV3_r*>@L}07zg8t&|D(AQ2muVttaa?GD5JP*Ws*4ug z?^(mFFLM~$IkQ3B{X0$@Jp&n3A7G@6By&FXLG3yI;52|rL>k2DG1*@^eX;Pw>1_p6 xAVlvIr+?J|jSae 251.182.120.32:443 [proto: 91/TLS][Encrypted][Confidence: Match by port][cat: Web/5][13 pkts/9962 bytes <-> 13 pkts/2201 bytes][Goodput ratio: 93/67][84.45 sec][bytes ratio: 0.638 (Upload)][IAT c2s/s2c min/avg/max/stddev: 186/186 7406/5844 21467/15787 7157/5701][Pkt Len c2s/s2c min/avg/max/stddev: 56/56 766/169 1328/189 433/46][Plen Bins: 0,0,0,0,51,0,0,0,0,9,4,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,4,0,9,9,0,0,0,4,0,0,4,0,4,0,0,0,0,0,0,0,0]