Added check in TLS 1.2+ for reporting a risk when TLS is not used to carry HTTPS

This commit is contained in:
Luca Deri
2020-06-08 14:20:10 +02:00
parent d318285cae
commit 3506a07864
22 changed files with 86 additions and 71 deletions
+6
View File
@@ -50,6 +50,11 @@ typedef enum {
ndpi_l2tp_tunnel,
} ndpi_packet_tunnel;
/*
NOTE
When the typedef below is modified don't forget
to update ndpi_risk2str (in ndpi_utils.c)
*/
typedef enum {
NDPI_NO_RISK = 0,
NDPI_URL_POSSIBLE_XSS,
@@ -66,6 +71,7 @@ typedef enum {
NDPI_HTTP_NUMERIC_IP_HOST,
NDPI_HTTP_SUSPICIOUS_URL,
NDPI_HTTP_SUSPICIOUS_HEADER,
NDPI_TLS_NOT_CARRYING_HTTPS,
/* Leave this as last member */
NDPI_MAX_RISK
+3
View File
@@ -1495,6 +1495,9 @@ const char* ndpi_risk2str(ndpi_risk_enum risk) {
case NDPI_HTTP_SUSPICIOUS_HEADER:
return("HTTP Suspicious Header");
case NDPI_TLS_NOT_CARRYING_HTTPS:
return("TLS (probably) not carrying HTTPS");
default:
snprintf(buf, sizeof(buf), "%d", (int)risk);
return(buf);
+6
View File
@@ -1381,6 +1381,12 @@ int processClientServerHello(struct ndpi_detection_module_struct *ndpi_struct,
#endif
}
/* Before returning to the caller we need to make a final check */
if((flow->protos.stun_ssl.ssl.ssl_version >= 0x0303) /* >= TLSv1.2 */
&& (flow->protos.stun_ssl.ssl.alpn == NULL) /* No ALPN */) {
NDPI_SET_BIT(flow->risk, NDPI_TLS_NOT_CARRYING_HTTPS);
}
return(2 /* Client Certificate */);
} else {
#ifdef DEBUG_TLS