tftp: check incrementation for DATA and ACK packets

The 2 bytes following the opcode for DATA and ACK packets are the
block number and this should be incrementing every packet.
We should check to see that this is occurring otherwise false matches
can occur, eg L2TPv3 over UDP matches the DATA opcode but the next two
bytes are always zero.

Remove the DATA max block size assumption since this can be false if
the blksize option is used to increase it.

Fixes #2070
This commit is contained in:
Thomas Winter
2023-09-12 13:12:14 +02:00
committed by Ivan Nardi
parent 7263562514
commit a5f0cb7e6c
2 changed files with 25 additions and 1 deletions
+4
View File
@@ -921,6 +921,10 @@ struct ndpi_flow_udp_struct {
/* NDPI_PROTOCOL_LINE_CALL */
u_int8_t line_pkts[2];
u_int8_t line_base_cnt[2];
/* NDPI_PROTOCOL_TFTP */
u_int16_t tftp_data_num;
u_int16_t tftp_ack_num;
};
/* ************************************************** */