Fix detection of NDPI_TCP_ISSUES flow risk (#2177)
We need to take into account retransmissions: they increase `flow->all_packets_counter` counter but not `flows->packet_counter` one. Therefore, the right way to check for 3WH + RST pattern involves checking for `flows->packet_counter == 0`
This commit is contained in:
+2
-2
@@ -7107,12 +7107,12 @@ static void ndpi_check_tcp_flags(struct ndpi_detection_module_struct *ndpi_str,
|
||||
|
||||
if((flow->l4.tcp.cli2srv_tcp_flags & TH_SYN)
|
||||
&& (flow->l4.tcp.srv2cli_tcp_flags & TH_RST)
|
||||
&& (flow->all_packets_counter < 5 /* Ignore connections terminated by RST but that exchanged data (3WH + RST) */)
|
||||
&& (flow->packet_counter == 0 /* Ignore connections terminated by RST but that exchanged data (3WH + RST) */)
|
||||
)
|
||||
ndpi_set_risk(ndpi_str, flow, NDPI_TCP_ISSUES, "Connection refused (server)");
|
||||
else if((flow->l4.tcp.cli2srv_tcp_flags & TH_SYN)
|
||||
&& (flow->l4.tcp.cli2srv_tcp_flags & TH_RST)
|
||||
&& (flow->all_packets_counter < 5 /* Ignore connections terminated by RST but that exchanged data (3WH + RST) */)
|
||||
&& (flow->packet_counter == 0 /* Ignore connections terminated by RST but that exchanged data (3WH + RST) */)
|
||||
)
|
||||
ndpi_set_risk(ndpi_str, flow, NDPI_TCP_ISSUES, "Connection refused (client)");
|
||||
else if((flow->l4.tcp.srv2cli_tcp_flags & TH_RST) && (flow->packet_direction_complete_counter[1 /* server -> client */] == 1))
|
||||
|
||||
Reference in New Issue
Block a user