From b68b45f3bbc0754427f04e393c66a9f3e69188ff Mon Sep 17 00:00:00 2001 From: Nardi Ivan Date: Sat, 6 Jun 2020 15:54:44 +0200 Subject: [PATCH] TLS: extract JA3 signatures in some corner cases In some (rare) cases, Client Hello message contains lots of cipher suits. --- src/lib/protocols/tls.c | 4 ++-- tests/pcap/ja3_lots_of_cipher_suites.pcap | Bin 0 -> 5332 bytes tests/pcap/ja3_lots_of_cipher_suites_2_anon.pcap | Bin 0 -> 7422 bytes tests/result/ja3_lots_of_cipher_suites.pcap.out | 8 ++++++++ .../ja3_lots_of_cipher_suites_2_anon.pcap.out | 8 ++++++++ 5 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 tests/pcap/ja3_lots_of_cipher_suites.pcap create mode 100644 tests/pcap/ja3_lots_of_cipher_suites_2_anon.pcap create mode 100644 tests/result/ja3_lots_of_cipher_suites.pcap.out create mode 100644 tests/result/ja3_lots_of_cipher_suites_2_anon.pcap.out diff --git a/src/lib/protocols/tls.c b/src/lib/protocols/tls.c index c9b2d0ee2..007931e19 100644 --- a/src/lib/protocols/tls.c +++ b/src/lib/protocols/tls.c @@ -818,14 +818,14 @@ static void ndpi_int_tls_add_connection(struct ndpi_detection_module_struct *ndp /* https://engineering.salesforce.com/tls-fingerprinting-with-ja3-and-ja3s-247362855967 */ #define JA3_STR_LEN 1024 -#define MAX_NUM_JA3 128 +#define MAX_NUM_JA3 512 struct ja3_info { u_int16_t tls_handshake_version; u_int16_t num_cipher, cipher[MAX_NUM_JA3]; u_int16_t num_tls_extension, tls_extension[MAX_NUM_JA3]; u_int16_t num_elliptic_curve, elliptic_curve[MAX_NUM_JA3]; - u_int8_t num_elliptic_curve_point_format, elliptic_curve_point_format[MAX_NUM_JA3]; + u_int16_t num_elliptic_curve_point_format, elliptic_curve_point_format[MAX_NUM_JA3]; }; /* **************************************** */ diff --git a/tests/pcap/ja3_lots_of_cipher_suites.pcap b/tests/pcap/ja3_lots_of_cipher_suites.pcap new file mode 100644 index 0000000000000000000000000000000000000000..86fc74712d45519619abc415464a461af0006124 GIT binary patch literal 5332 zcmdT|d0fnE7eBvQ+ne^iCW%t=n>Hm{Xj4gxw20P0RKsXPXr@GD=@ONt#hxscoy)0| zTahJPS;HVpWVyDB-rwYNz4W^8`~G{M&*zyr&-u;oJI^`KIp6a<&*g@iavCt;uh!cO zKv09*N!KIAVe;TZ$aHTX&~OOE~&Q(Hf$_ZWaColZ9*fUZZU*AjJF+_m;G!?uin|LE~P z`M{1nCpot^z`^Pf?fymg3xIY4l%Wv{u>ciuH!cDdXaG}O0;^y*GO!qZ!0D{IL>=mI z0}R3hsD)}A2y0;scpx7}VFiZ53RD9f(1HYs9>k;ESq+H}Yy)$2#z~lRRt+OT6}50N z32kejpGhB#VaKKWq1Rf59gJ6YG zC_pPL0y=B}8Vo}h)Q9yr1P+5UWHFcNIw z6k6b5s6bx~hJmO=MYTH`qB|H#v~dL-gF|pYqKhmXjbm{PER(2$H^{+q7!DeMuo=ae zkAqMd_>hlzxCQ6H5KP9&I30{}J=EZEi9VX+8rX-a=tgCR5-Q+Yi3(^#F9FoL$pMS< zuog8|qydEZHHs-ns7-2|}I;q-Z}+o|I+LLl`VIT1YTY zg;bUfWE5ol`RUwnfp8{ImE=fOYz5gMLELoyoD{y0r%P%}b#e+SVSJ$=gF8kboFx#( zq$CKEc^0I(^qIWE055(rUziZb4H5`axMTRjl!U1XaWN@;u3Ku#bb&A-WiF3L4wL?v zu3+{R=zqUL8fq!>9C$oyN1lV-aBJ%bEk$da?}ntP=0}s%Nmc1z$SBB<5hN$`<5Cjh zQd4*wQc0?1E3o|q!t|KLng7+MLFB-%HW_#&3SwgtxdB2!d}>?@*PWl3kj59z<$4JP zsk3<6q~=$1l*59;9LG4?*m^kHI(m9|@(f75Z=RPWG?h~4@P)1!Qs-I436e-LG2r{9 zA(%iH6Usp8UvC>z2=8-C zZ*(-ewB_lMo!rY2TF2(__c@2pzZiUCbK9h{i~4tVtlzk@o5S?i2w8u)(eF-bVeRKv zLC(?a0()^sPDQB6U1|KVP3e$vN7NM$ z{sXevw(I`(#TB+)BgZ;kq|vGP-XbO%DUa0k1+0M@gGNH%DjFygL@$Fur_sAe6_#vt zt~ZhUel)cipj6CGa`3-ZiVR&%?XQvM&QD8-<9{EPqzAQj2Br*WawJQ}f<-WyY&!8x zqJ5JX-z4TYiSURfxtSiv%ccOnGp)}%;xeJ zUp`kHdr$w%lAxBWy{APl9&C)0jc6Nle&CdCEzOyiglcU@#yj(0434}v-KcZx-d@Ab z!zJtg$fkSDW^aGA{&g))u4(cchKZ*C5Wc2ugm$Cn+x8qK&q}uhxiZ_R&2gg(<~yVh z%j-C;I52nMQ~jpgwN{3M4N7+xkGHYav1_3z%r@Lw`ec$zx37C-Qi<|J?uk!PorgN! zUMQ1R0Gt1>0xyfj>n6`ShcbNVA+_N1~*`6+VgrVyuUYS;0WV*Xd8n11~$`xCT& zPX8xTKbN9@J03;$);4z5wq%61vNcJ4+w$xvg`=Hg#6Quf|3&?~GZSr8a?^WE2Mjm_ zjaCJFSta%N+Ko%x)?{$Zdt8#BM5W}Ecyutq_6a;oPj7g+>UZan*4Y(~W6tI)S`%^` z4o~s=c;9N`N;7#+{wGsxO{A%G2-c;F+L~s6%=<81?n-p#==pm-4UBere`I{5iSwP6 zg{FFOtAAgRJ~{J7PHmpcE75^^7Bl38x=~}i`@X!x4q5GbIq> zEMZmZ*^W*nmrwqRmm;?Xtb6!rVTu2iLC){OBThy3+`ia|jiQmYR+T#OXHM#6yqu$` zJ;PnaZ2J(MKcb7)nP-hluHSn#?T#Ax@%6E*$v)?JNvd;RTZ+`%2(Q1WUxlK6#qXHs zr^F(<^_6-=S4h#NpOa6y=+IVC?LRP5#8eI|NX=7YFiAR9^7>_TAB{%Vl~qo&Iw}rc zD9;bGOPk3m6Bbz1(+qZ`M$AxK)H)^E$<$7ws4S69;LW^U_+`zCQ>DH~AG2x4?JG3w z&ICqz)IlgqHBe@#XG49Gvaonu)@QD^!|s#2ura+{tpCFFO^#f$b6C~83rTyFlc8|z zvh5?TXx6AQ%_o*P%Rb|bh?zSubisU@(>isJ-mp!Ymy+yLBZ?*nCb$;|tg5Vc*x;x2 zz;U{-F>j;O!HTvUZ@pvI@uEXXSKE7j7bDZ$Ea*=|If{2*2D=A^yuUA0WDnArVRqzI ztk%q79}ShC{krr0$OB8mTDTKO(N~wfyB?@u{fj#elgS?cM9DjUxJg!_^!Tf+0Caf* z8se_$#%OTPS>A4b*&S#k*?X-)V@^QbZQW@vB8l^5Nk!K*cdRP9UOIZTG5dU8!IiGx zT(xd3{Io|a?$Oeos)FY5DK(w@$s_x`y&t9c%iehJGNCxIJn>f3Ztm~y+6I#hdM#5X zb`NWxc*=a?(2(Pj%&V5t3Q$W`fZNp0UE2Td3_$y>izTf98R8!+z~O^^6+jynrF8>X zxXgRAC-eZ_{Mf(~=1$7!B@?`DRfO-6oAZZMC)8`5(=%Tfo^m|uT*0gk+q7-AD@^iw zY&*hNCRpCxpV-`<{(NUujissbv4bn)&3ZRHTe-S!7Oi&Yy?aVcb&BWS$YkyGlTEs2 z6qKcMzTr_q^z63DoO#NwW@W}QT^(1-559FNOSUw-m|B%S&6D5Upk+fHn+OnHuz7ai zzL8BqX4D!|j1OuJs>S zjjg`@EFypLGC#ef3-=^zjuntm#o>)U)xE0Zc_YlUS^oRpw;jv@W{L;pIA;wVD_u6s zkC|HQ;iPnYK;4rCR__*Mv?aIN9`HS5=&qZPVQBi{yiTE;QHx5Tp@YjVa*(ZwPVk+z z5&A=QtsXyS^mZTCjgW8iK3iIq6Po?bevoy>V1s$(E7?{GlRRBp0=6DxZauT}TDQf7 zYy+#{)c8q-&5MJd?g?4t+>vF~`0JrORjUQ}J^0P7Cks+kLOzWbRFENu%%aZhJ$=X1 zmtPgIaYji2m0`e8qC#65?R)%`{-3)rzrMS$n?K%Lb(q#MYlr}j(Ub$!iT7)hVlD{m zkNKacXfW$yOEYM`@sAmFEQHD+OX2mIa#9&>tAS1zd&J5RDZ?_>bvT3}0f0e}WRE-d`c7nY0ux1<>y7#zTU z0OS{e25QG)FDm?=48RVGz6Q{slU#rblPfR!H)fB9pz5@m2i_pWY_uxF)e!*DSlo3i znt=&0-zrD$qc9j8q5yca0V;fr44BOkDFW+wSI7@50KiHx3jj6zg_8&!Q9)B+0MA?m zJ2WfRk05kdBao*{*F(sN0#w~-h}i(j239bZ&FL;O){q1hLF|{pt+Ia%RzV5jK(&OM!1kgL+i$ZX z3J~(mXhwiS1Av3aYBFkiXA?qpV_8l{4I^Y!2SWCwkx`E+1_)Wg<&R`uR7-BvKV&w9 zydHx>C7}T7ECyq7H`<{}s1g@_Hy_s#@x0C1|3QOH6cyKB9Kev8DP#yxbdWSe1ec*w z=rXhsk^oK+6SNMfLgmm^C<;0Q1w)>YFL(f=p)HUc$bw3sEQkP!1AB-O;sOd#8FU4T zgkqr}$OG~LcK{h;fH=W=Pz)77TR}CX49-F4pmgXWR1B^``H%{zf|Nialn7mbE$(0Y`xxM1mwCHb@5A1Yx0U zC;;3Bnou0%2Sr0(fC*xSFrXCN1SwE5lm<#b4LA=aL8%}a6hV2Q9K=HjPzqE83ZYz3 z2I8Qz(0Qm3oB@k)u2{k$!UgaEu#r^dWtCNBNearcBo$S_3Y)Wz4nv2+VQ?rc1`Ed( z28G6;QGf~X!k_U00r>9*zyrVM2i#yC{570_8Nd_ZI{>~90096bARc6~06X{+8UIQI zbG1Pv5qx&9NCa(KA}Ib!1jWTKv_v?(DiJ7J%|pQ<9AF|uaw!-{)Ws<{6xk4}e+~=i z!U5V?O~pM>dxucno-U{2DiA6zdx?t6Ui^wsQ$G9`wVG}vbv*_Hl;EHzAt4y5!13wU zSMePOHmU}k%TB^U2U&bXzV`A3cHv6D83T|B03*Bru(x0@!T*VS#|&_z0QVQby(EU> z28f}UduT?`v!%zNc$R~M$V$g36{#0F!-_)TaDaHajKoZ2q{EnD>A29^WD+|(0lr{h zq1)?Cb)-0u@I-dx20aUduE%kztBvz<(k3DSxy8gH0MCIZQLL#VWKS<^8)rvP2bbei zFA-fAEj`i(A|Eo1nT2y{8a(TutA~@Fs|V#ciJQoUe28ITarylnvbM)bB1EBo^f98= z;~lAXt{Tf{5QTVHNy;R7c@jw#jx@zX@TDqI6~47}`9IH~P_)?cMM2>JCKSyMh@ogE zbSRt!_o`1;G={y{Kd?z@v25S>qhi*ZH=EgidUTyRq|`}g{VA;^(ZlgCH4jk(T$DvP zS-h_3Dqha1`RP8S_jP{j8@d=l-WS^DEkmiTdpuJZUUWrVXLsG7zAi0!hMj+!3fNg&Rexl&5;0G1s{2;F7rg*ZSDJTN!7{JV&tosq zq${5+Y&CMwL%c0wd`k6=vP!>y=7NFC!3ndLY1wd1OQD{@KEZAC&z($lvJ9rbw(#8R zZO@X#i%jh$*FN-hXb@qJoqzGjx*(wOFPxpOqQJ#BXWf-#eje!U>i~T3%SIJRqjMX^ zeLIDNuRHs)qB345S8}!J{8bhpQX*aac((lU9NC-WMAi5}iM-Cqy7hqDg55+Xy7f%W zsZmVWQTN8;OzP_cp={6S>-z~i4Ttw@5BPPqZ?Wh)I+U#59~rn~;{s)H)W-w8T`tGS z&7xIDH(p(xYVH2~wI09FL-`IioSf+OSflr2$C&gzPtEtqp~+H5q!vPVpNaXF^_*;s z3hdsziBswAvvEE<^O4v9!$h7JZ4~?0>*R-;T=c}-VghVD#eRJ2>_}0udT1};BT6_Q z6?lHemf*wCWZf!9pf9!U)J&>3`)n@Q*C-&+DL@{36Z|XzYkdf7)TH&^@@<9eNT*>u z!(j1_w`dHU-OD2cPFpxaP(U9DbN4q-6>53;DdMzr0^c@JB-}0;at&8LEU!OCI-J>a zJAd(6wQD_^=`K?sQNpj6Bi2sh^Px}!^R1N0lFf=2Spr{8-?pvlCgi2$bha`V4B3;U zq)p2r4%)rx^RS=YZI(JS?xvIV1I4%dpG(%7+31y1c&inF#)ERN{4PuK_puecOkYnWlkY&xDPnED~P? zbz-QoG5d9IgW$$(YMU0zyOSB%+t(+eV_NN4tVCaqWgW47JJ8y(5UD!fdSA+}!YcO; zIq(J3ky3Eu!`5{(9u}4o+xM719`p!OO1wfob&kE3$4}qXQCQe$>(7C$PP&FuO-<$O z7OomM-!9r`ykH_bVP%E4-o)2>^w!nGk4@az z-0erk$>=_A)tPm}c8{pV?{zT7VNThd$~c)P_jI(zQ`mi+oBas_O2*wtlZIBMWN zhY9hA*#LdA3u1pF4tT@r{Qq#QK-*V7L{!YBELVYs4=3`A=v|14K$;4)I%PkiLi~>^ zLU_@HyZ8Q4(Mf_;z-fb~;{a$h8l=9v!~5dNCj*?w-;p8IVVy`R?=GRs1uZhug{01m zP+}e4i%Pt`_136i`^XbX`4V6K-ni(XjHAbEw@{|SwuM)3VSZp`#LjxdvHQo7n6W5k z-wmF&M@4vrZzyxql_#)c)X^=LVuzmlm1lev9O^(T@wwMOVV$Jo?i$^`yEskFZ2lw0 zE}19jUCF?Qvc^j`H`OJ-#7fIO5ECwsF4`q<&hN6%TuGp^! z_a(MFcfF%@xSNUJ8M;Q7A;H?}5VA+3DYmXN^OLB3mce-536`M3yw-89*+6o6jIDNj zYNJnO)axwkBpK(TM$Y=0{PXiO^IslohJ}`Ja~&qjvr419}kxuw~R{V(~4qj7I*Eb zIHVAKuEEKti~8=$0il-4Nd1DJNsPzZJ_afU;>|4b%^7!UYc@KqJMrv7zDh9vUwozd z!gZ6?+PL)L>e@HQyJZN%S(0%Q7yT@mG9C*}7Pfjmk+1W%6BHv`93HwAe_-fjrMTs; zrn5u`XH%C6b)}k_+7W`M1^U$-uO7cm_M-*9L)9wUx?k>UMkllh-@AKN=)OSv7qOu3 zweOK_k zY5d~|KX{36O);kNJ6G|~{^k$4uH++ohXhQdz1n(g`f=57wpq;|!5kPFWb5kBthN21 zKk;3BG`z^hRu7S>sm{2@iSI!>vcF83E#F_j>J#604dl_s!Ik?9eX>^b%V_w-H|=1x zB$4FGRs~ndPK4?ez819!UK}<22WU;|4;uBrAE;+(RJfKS)e)vX_)S%~!L)|0kKi++ z8vbv=HL0^SD(sKtk9lae)*)2;C%>ue@Ckd#)=rqZ3GRE4@vq*8=Me)!oj9_bio(!( zpXpz{&-CI?gu1%-`95+t+D-Yx15tvC>wq<)JG6*KlMZVHojT?^|1Rs zSN2!yGe`{0p6VclPN=Vp`rS*0OlZaB>3?RS^99M3of9D&XJKj2ls*2mEVeJqk!5*)cg3>6 zH28_G#;^F%SX`hj3whPDL?X*l0jK)=$G?{ae*$q3(geYuokc!J6!;d1gZbwG~2O36f?y3P1S#}Jrdb};{Ry^>s}+a^I$O8U9io_ z3$?o_eM`UlK9n;L+vLv41Xs1Zrg1=JVrd>cuP#|DWiz!SZrk+{J>Qy{oep((SXH>H z(nJU;Q!-xU=4^MLFCT)z_zA*2iYU5K%sL>`FW0W6{0?7m$H+V8@86T#CIgt)8&@Uo z{o;jp(yBZ+^y+$^;B;<(tD`o7e!|2z=CM)G^Sh2$OC5gZJ-q8YHy-@<;7xTIPtK_` z55k2W(%V5>Y;BNFnljzrue6U3Pj@BN;9_r5wL;FVec=pcpK(X@G zuY~@x>Cg{KA01*L9^1&Gpci<+Ebghh9w0kLckC3i>cWaFj$*H|YFWAr_<(fb~PB}*x%XHwNLk2u>^0_ zhwnA$=UltCcA8C$+uoY3rAsYM3Q5JN9KIA2et+M-wtkb+6JL&eGQWrM{Lr_{U-R1b zIekaXV;r))lR-E5+La>7g>U1i#G6!fZE#Yz zp{40srJ2CiRwvQc+vV!R;Y04*jf+p~ItSy?ociEhxln-Niwqe`oRI25z~0?iAy*nj z12Wm%*qke-Y#nR9R=>k3a_|07q^()~O=jq`rO*53iVSnQjtbUu2`aKmnhS@;aq=Qp zH`)|sTWh^PSA9S=gM4tt!}Eg%1b) zPIW70MsqlsiTlP+vKopBH>Bb(HmJ=JHymc%%FWLqZsTHjGBmmb%7 literal 0 HcmV?d00001 diff --git a/tests/result/ja3_lots_of_cipher_suites.pcap.out b/tests/result/ja3_lots_of_cipher_suites.pcap.out new file mode 100644 index 000000000..46d0c9b8b --- /dev/null +++ b/tests/result/ja3_lots_of_cipher_suites.pcap.out @@ -0,0 +1,8 @@ +TLS 11 5132 1 + +JA3 Host Stats: + IP Address # JA3C + 1 10.206.131.18 1 + + + 1 TCP 10.206.131.18:58657 <-> 10.206.65.249:443 [VLAN: 258][proto: 91/TLS][cat: Web/5][5 pkts/1144 bytes <-> 6 pkts/3988 bytes][Goodput ratio: 70/90][0.22 sec][bytes ratio: -0.554 (Download)][IAT c2s/s2c min/avg/max/stddev: 1/0 64/39 164/136 72/50][Pkt Len c2s/s2c min/avg/max/stddev: 68/68 229/665 866/1522 319/650][Risk: ** TLS Certificate Mismatch **][TLSv1.2][JA3C: 0463681bfef175d3d61ec414c65e482c][JA3S: 9d456958a9e86bb0d503543beaf1a65b][Issuer: C=US, ST=New York, L=Rochester, O=Xerox Corporation, OU=Generic Root Certificate Authority, CN=Xerox Generic Root Certificate Authority][Subject: C=US, ST=Connecticut, L=Norwalk, O=Xerox Corporation, OU=Global Product Delivery Group, CN=XRX9C934E949FEF, C=US, ST=Connecticut, L=Norwalk, O=Xerox Corporation, OU=Global Product Delivery Group, CN=XRX9C934E949FEF][Certificate SHA-1: 3B:2B:5E:58:6E:3E:30:1F:52:BF:9B:81:20:47:DE:10:A0:67:8E:FA][Validity: 2018-11-29 18:57:22 - 2023-11-29 18:57:22][Cipher: TLS_DHE_RSA_WITH_CAMELLIA_128_CBC_SHA] diff --git a/tests/result/ja3_lots_of_cipher_suites_2_anon.pcap.out b/tests/result/ja3_lots_of_cipher_suites_2_anon.pcap.out new file mode 100644 index 000000000..3f789f4cd --- /dev/null +++ b/tests/result/ja3_lots_of_cipher_suites_2_anon.pcap.out @@ -0,0 +1,8 @@ +TLS 27 6966 1 + +JA3 Host Stats: + IP Address # JA3C + 1 192.168.147.177 1 + + + 1 TCP 192.168.147.177:58496 <-> 151.121.193.160:443 [proto: GTP:91/TLS][cat: Web/5][13 pkts/3520 bytes <-> 14 pkts/3446 bytes][Goodput ratio: 60/59][5.96 sec][bytes ratio: 0.011 (Mixed)][IAT c2s/s2c min/avg/max/stddev: 0/0 479/256 1619/1072 582/419][Pkt Len c2s/s2c min/avg/max/stddev: 106/90 271/246 1202/1490 315/354][Risk: ** Self-signed Certificate **** Weak TLS cipher **][TLSv1.2][Client: 192.69.136.179][JA3C: 50221ef5bde0fcee8864bbcea5211d51][JA3S: 7c02dbae662670040c7af9bd15fb7e2f (WEAK)][Issuer: C=DE, ST=Munich, L=Grenoble, O=Munniccan Establishment GmBH, OU=Munnican Workforce, CN=munniccan.de][Subject: C=DE, ST=Munich, L=Grenoble, O=Munniccan Establishment GmBH, OU=Munnican Workforce, CN=munniccan.de][Certificate SHA-1: 91:0C:1D:82:6B:28:01:8F:55:03:28:5B:90:A9:18:B9:ED:72:01:37][Validity: 2016-12-21 19:19:24 - 2019-09-16 19:19:24][Cipher: TLS_RSA_WITH_AES_256_GCM_SHA384]