Fix classification "by-port" (#1851)

Classification "by-port" should be the last possible effort, *after*
having test all the LRU caches.

Remove some dead code from `ndpi_detection_giveup()`:
`flow->guessed_protocol_id` is never set to any od those voip protocols
and at that point in this function we never have both a master *and* a
application protocols.
Coverage reports (both from unit tests and from fuzzing) confirms that
was dead code.
This commit is contained in:
Ivan Nardi
2023-01-17 08:26:42 +01:00
committed by GitHub
parent 1f7c57deff
commit ebb9ebd2a0
60 changed files with 92 additions and 118 deletions
+1 -1
View File
@@ -5,7 +5,7 @@ Confidence Match by port : 639 (flows)
Confidence DPI : 22 (flows)
Num dissector calls: 264 (0.40 diss/flow)
LRU cache ookla: 0/0/0 (insert/search/found)
LRU cache bittorrent: 0/0/0 (insert/search/found)
LRU cache bittorrent: 0/1917/0 (insert/search/found)
LRU cache zoom: 0/0/0 (insert/search/found)
LRU cache stun: 0/0/0 (insert/search/found)
LRU cache tls_cert: 0/0/0 (insert/search/found)