Ivan Nardi
adf8982d8e
fuzz: extend fuzzing coverage ( #2205 )
2023-12-11 12:48:50 +01:00
Ivan Nardi
f74cf16c36
OpenVPN: rework detection ( #2199 )
...
Close #1873
2023-12-06 10:24:26 +01:00
Vladimir Gavrilov
ad20846fad
Add Ether-S-Bus protocol dissector ( #2200 )
2023-12-05 17:20:38 +01:00
Vladimir Gavrilov
be50493f44
Add IEEE C37.118 protocol dissector ( #2193 )
2023-12-05 08:06:15 +01:00
Vladimir Gavrilov
c34bded4ef
Add ISO 9506-1 MMS protocol dissector ( #2189 )
...
* Add ISO 9506-1 MMS protocol dissector
* Fix detection on big-endian architectures
2023-12-01 09:03:07 +01:00
Ivan Nardi
983b8e8eee
STUN: parsing of DATA attribute ( #2179 )
2023-12-01 07:01:49 +01:00
Vladimir Gavrilov
24df1913ac
Add Beckhoff ADS protocol dissector ( #2181 )
...
* Add Beckhoff ADS protocol dissector
* Remove redundant le32toh
* Fix detection on big-endian architectures
2023-11-30 09:13:45 +01:00
Ivan Nardi
6f046df0dc
STUN: fix detection of DTLS ( #2187 )
...
Fix a memory leak
```
==97697==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x55a6967cfa7e in malloc (/home/ivan/svnrepos/nDPI/fuzz/fuzz_ndpi_reader+0x701a7e) (BuildId: c7124999fa1ccc54346fa7bd536d8eab88c3ea01)
#1 0x55a696972ab5 in ndpi_malloc /home/ivan/svnrepos/nDPI/src/lib/ndpi_memory.c:60:25
#2 0x55a696972da0 in ndpi_strdup /home/ivan/svnrepos/nDPI/src/lib/ndpi_memory.c:113:13
#3 0x55a696b7658d in processClientServerHello /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:2394:46
#4 0x55a696b86e81 in processTLSBlock /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:897:5
#5 0x55a696b80649 in ndpi_search_tls_udp /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:1262:11
#6 0x55a696b67a57 in ndpi_search_tls_wrapper /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:2751:5
#7 0x55a696b67758 in switch_to_tls /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:1408:3
#8 0x55a696c47810 in stun_search_again /home/ivan/svnrepos/nDPI/src/lib/protocols/stun.c:422:4
#9 0x55a6968a22af in ndpi_process_extra_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:7247:9
#10 0x55a6968acd6f in ndpi_internal_detection_process_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:7746:5
#11 0x55a6968aba3f in ndpi_detection_process_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:8013:22
#12 0x55a69683d30e in packet_processing /home/ivan/svnrepos/nDPI/fuzz/../example/reader_util.c:1723:31
#13 0x55a69683d30e in ndpi_workflow_process_packet /home/ivan/svnrepos/nDPI/fuzz/../example/reader_util.c:2440:10
#14 0x55a69680f08f in LLVMFuzzerTestOneInput /home/ivan/svnrepos/nDPI/fuzz/fuzz_ndpi_reader.c:135:7
[...]
SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s).
```
Found by oss-fuzzer
See: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64564
2023-11-30 09:09:40 +01:00
Ivan Nardi
ac90b1f009
Fix detection of NDPI_TCP_ISSUES flow risk ( #2177 )
...
We need to take into account retransmissions: they increase
`flow->all_packets_counter` counter but not `flows->packet_counter`
one.
Therefore, the right way to check for 3WH + RST pattern involves checking
for `flows->packet_counter == 0`
2023-11-29 16:55:39 +01:00
Vladimir Gavrilov
c60c03766c
Add Schneider Electric’s UMAS detection support ( #2180 )
...
* Add Schneider Electric’s UMAS detection support
* Swap proto IDs in ndpi_set_detected_protocol
* Update unit test result
2023-11-28 18:03:00 +01:00
Vladimir Gavrilov
ebb1bc2f34
Add Ether-S-I/O protocol dissector ( #2174 )
2023-11-27 19:04:05 +01:00
Vladimir Gavrilov
84427b0754
Add Omron FINS protocol dissector ( #2172 )
...
* Add Omron FINS protocol dissector
* Add a kludge to avoid invalid FINS over UDP detection as SkypeTeams and RTP
* Update unit test results
* Update protocols.rst
* Remove dummy flows from fins.pcap
2023-11-27 17:09:53 +01:00
3763c702f0
Rework S7Comm dissector; add S7Comm Plus support ( #2165 )
...
* Rework S7Comm dissector; add S7Comm Plus support
* Cleanup s7comm.c
* Improve S7Comm Plus detection
* s7comm/s7commplus: faster detection
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
Co-authored-by: Nardi Ivan <nardi.ivan@gmail.com >
2023-11-27 14:37:48 +01:00
Vladimir Gavrilov
0b6e261523
Improve CORBA detection ( #2167 )
...
* Improve CORBA detection
* Remove dummy flow from ziop.pcap
* Merge ziop.pcap and miop.pcap into corba.pcap
2023-11-27 13:10:50 +01:00
Vladimir Gavrilov
da629709f3
Add OPC UA protocol dissector ( #2169 )
2023-11-27 12:13:23 +01:00
Ivan Nardi
7ff22a7e3c
STUN: improve demultiplexing of DTLS packets ( #2153 )
...
Keep demultiplexing STUN/RTP/RTCP packets after DTLS ones.
We might end up processing the session a little longer, because we will
process the STUN/RTP/RTCP packets after the DTLS handshake.
2023-11-27 11:10:38 +01:00
Vladimir Gavrilov
87399b3544
Add RTPS protocol dissector ( #2168 )
2023-11-27 07:17:39 +01:00
Vladimir Gavrilov and 0xA50C1A1
27802b0134
Reduce false positives for H.323 over TCP ( #2164 )
...
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-23 17:29:00 +01:00
fbae51ae9d
Get rid of RDP false positives ( #2161 )
...
* Get rid of false positives in the RDP protocol dissector
* Remove kludge for RDP
* RDP: improve detection
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
Co-authored-by: Nardi Ivan <nardi.ivan@gmail.com >
2023-11-23 09:35:43 +01:00
Vladimir Gavrilov and 0xA50C1A1
5c8c5c90c2
Add HART-IP protocol dissector ( #2163 )
...
* Add HART-IP protocol dissector
* Update docs
* Update protocols.rst
* Reuse free proto id and re-run tests
* docs: move HART-IP to top of list
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-22 22:04:22 +01:00
Toni
21f2574033
Improved TFTP. Fixes #2075 . ( #2149 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-11-21 16:56:46 +01:00
Vladimir Gavrilov and 0xA50C1A1
35abafec4f
Get rid of Apache Cassandra false positives ( #2159 )
...
* Rewrite Apache Cassandra dissector
* Replace memcmp with strncmp
* Add payload length check
* Update Cassandra dissector
* Update test results
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-21 16:56:01 +01:00
Vladimir Gavrilov and 0xA50C1A1
ae6e6d61f0
Add IEEE 1588-2008 (PTPv2) dissector ( #2156 )
...
* Add IEEE 1588-2008 (PTPv2) dissector
PTPv2 is a time synchronization protocol in computer networks, similar to NTP.
* Add default protocol ports
* Update default test result for PTPv2
* Update copyright
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-21 13:39:54 +01:00
Vladimir Gavrilov and 0xA50C1A1
8d71998670
Remove Google+ support ( #2155 )
...
* Remove Google+ support
Google+ was discontiued in 2019, so I think that its protocol id can be freed for reuse.
* Fix typo
* Update tests
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-21 08:14:20 +01:00
Ivan Nardi
bdb73db1a4
IP lists: aggregate addresses wherever possible ( #2152 )
...
See #2150
2023-11-17 12:26:23 +01:00
Toni
38f9a74713
Added TeslaServices and improved TikTok host names. Fixes #2140 . ( #2144 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-11-10 11:25:10 +01:00
Toni
0673da54b5
Fixed implicit u32 cast in ndpi_data_min() / ndpi_data_max(). ( #2139 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-11-09 10:16:57 +01:00
Ivan Nardi
b539b0d090
fuzz: improve coverage and remove dead code ( #2135 )
...
We are not able to remove custom rules: remove the empty stubs (which
originate from the original OpenDPI code).
`ndpi_guess_protocol_id()` is only called on the first packet of the
flow, so the bitmask `flow->excluded_protocol_bitmask` is always empty,
since we didn't call any dissectors yet.
Move another hash function to the dedicated source file.
2023-11-07 17:46:29 +01:00
Toni
6dcecd73d3
Added malicious sites from the polish cert. ( #2121 )
...
* added handling of parsing errors
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-11-02 09:04:04 +01:00
Christian Marangi
d5c9a16a48
Move from PCRE to PCRE2 ( #2134 )
...
Move from PCRE to PCRE2. PCRE is EOL and won't receive any security
updates anymore. Convert to PCRE2 by converting any function PCRE2 new
API.
Also update every entry in github workflows and README to point to the
new configure flag. (--with-pcre2)
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com >
2023-11-01 14:16:49 +01:00
Ivan Kapranov and Ivan Kapranov
5a2666ce9e
Fix proto_name and proto_id missmatch for Sina and SinaWeibo ( #2131 )
...
* minor fixes
fixed 'handle leak' in ndpi_load_malicious_sha1_file and removed the redundant comparison ndpi_search_eaq
* fix Stack overflow caused by invalid write in ndpi_automa_match_string_subprotocol
* fix compile errors
* fix
* Fix name missmatch for Sina and Sina Weibo
* fix
* add Sina Weibo to doc
* fix
* add Sina Weibo to doc
---------
Co-authored-by: Ivan Kapranov <i.kapranov@securitycode.ru >
2023-11-01 14:12:49 +01:00
Ivan Nardi
50006516b3
Custom rules: fixes for Windows ( #2130 )
...
Even after adding `WSAStartup()` call, the behavior with IPv6 addresses
was different on Windows; it is the same issue reported on:
https://stackoverflow.com/questions/66755681/getaddrinfo-c-on-windows-not-handling-ipv6-correctly-returning-error-code-1
Fix bitmasks.
2023-10-31 16:04:30 +01:00
Ivan Nardi
42d24f8799
STUN: major code rework ( #2116 )
...
Try to have a faster classification, on first packet; use standard extra
dissection data path for sub-classification, metadata extraction and
monitoring.
STUN caches:
* use the proper confidence value
* lookup into the caches only once per flow, after having found a proper
STUN classification
Add identification of Telegram VoIP calls.
2023-10-30 10:28:19 +01:00
Luca Deri
76829b413f
Implements support for symbolic host names ( #2123 )
2023-10-29 22:54:45 +01:00
Ivan Nardi
03fd155ae3
IPv6: add support for custom categories ( #2126 )
2023-10-29 12:56:44 +01:00
Ivan Nardi
32b50f5aa4
IPv6: add support for IPv6 risk exceptions ( #2122 )
2023-10-29 12:14:20 +01:00
Ivan Nardi
c711251578
IPv6: add support for custom rules ( #2120 )
2023-10-29 11:26:35 +01:00
Ivan Nardi
e8e4b9e8ff
IPv6: add support for IPv6 risk tree ( #2118 )
...
Fix the script to download crawler addressess
2023-10-27 13:58:15 +02:00
Toni
ed17f4d658
Improved Protobuf dissector. ( #2119 )
...
* tag extraction/validation was done wrong
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-10-27 10:19:47 +02:00
Ivan Nardi
8b07be4b9f
Jabber: remove support for UDP ( #2115 )
...
Jabber/XMPP is only over TCP (even the name `ndpi_search_jabber_tcp`
suggests that...).
Bug introduced in 5266c726f
2023-10-26 20:16:27 +02:00
Ivan Nardi
611c3b66f0
ipv6: add support for ipv6 addresses lists ( #2113 )
2023-10-26 20:15:44 +02:00
Maatuq
4a8e7105b2
add ethereum protocol dissector. ( #2111 )
...
as explained here for bitcoin https://www.ntop.org/guides/nDPI/protocols.html#ndpi-protocol-bitcoin
the same is applicable for ethereum.
ethereum detection was removed from mining protocol and is now handled separately.
Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com >
2023-10-25 12:44:33 +02:00
Toni
e70333de87
Added generic Google Protobuf dissector. ( #2109 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-10-24 12:18:31 +02:00
Toni Uhlig
a443bba0dd
Add CAN over Ethernet dissector.
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-10-23 13:45:56 +02:00
Toni Uhlig
25c54dd6d7
Improved CryNetwork protocol dissector.
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-10-23 13:44:34 +02:00
Toni Uhlig
f69909d49b
Add Remote Management Control Protocol (RMCP).
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-10-19 19:50:57 +02:00
Toni
01f384f7ff
Improved Steam detection by adding steamdiscover pattern. ( #2105 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-10-17 22:13:02 +02:00
Luca Deri
b6179467eb
Added NDPI_MALWARE_HOST_CONTACTED flow risk
2023-10-13 00:01:55 +02:00
lns
304747f1fa
Improved MGCP detection by allowing '\r' as line feed.
...
Signed-off-by: lns <matzeton@googlemail.com >
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-10-11 16:44:26 +02:00
Nardi Ivan
4a0eda69ad
QUIC: export QUIC version as metadata
2023-10-11 15:15:20 +02:00