Vladimir Gavrilov
59c8eabc0e
Add UFTP protocol dissector ( #2215 )
...
* Add UFTP protocol dissector
* Update docs
* Merge pcap files
2023-12-18 11:21:07 +01:00
Vladimir Gavrilov
d8c7a76611
Add HiSLIP protocol dissector ( #2214 )
...
* Add HiSLIP protocol dissector
* Fix error
2023-12-17 11:52:55 +01:00
Vladimir Gavrilov
0f3e6d832b
Add PROFINET/IO protocol dissector ( #2213 )
...
* Add PROFINET/IO protocol dissector
* Add LE (Little Endian) to the file name
* Rework dissector
* Remove redundant check
2023-12-16 13:30:21 +01:00
Ivan Nardi
8ea16ffd77
TLS: be sure to always set a category value ( #2206 )
...
We probably need to check everywhere we set the category in the
"extra dissection" data path: a flow with a proper classification can't
have NDPI_PROTOCOL_CATEGORY_UNSPECIFIED as category.
2023-12-14 08:07:04 +01:00
Toni
ef62391dba
Add Monero protocol classification. ( #2196 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-12-13 19:55:18 +01:00
Ivan Nardi
bda037c57f
Sync unit tests results after latest merge ( #2211 )
2023-12-13 17:47:20 +01:00
Ivan Nardi
193f28582b
QUIC: add heuristic to detect unidirectional *G*QUIC flows ( #2207 )
...
Fix extraction of `flow->protos.tls_quic.quic_version` metadata.
2023-12-13 17:14:04 +01:00
Ivan Nardi
8e14aac5e0
ndpiReader: avoid creating two detection modules when processing traffic/traces ( #2209 )
2023-12-12 19:44:29 +01:00
Ivan Nardi
241c42ad7e
ndpiReader: fix guessed_flow_protocols statistic ( #2203 )
...
Increment the counter only if the flow has been guessed
2023-12-12 19:44:03 +01:00
Ivan Nardi
7b5354588b
fuzz: extend fuzzing coverage ( #2208 )
2023-12-11 19:24:17 +01:00
Ivan Nardi
b3f2b1bb7f
STUN: rework extra dissection ( #2202 )
...
Keep looking for RTP packets but remove the monitoring concept.
We will re-introduce a more general concept of "flow in monitoring
state" later.
The function was disabled by default.
Some configuration knobs will be provided when/if #2190 is merged.
2023-12-11 14:53:12 +01:00
Ivan Nardi
673b6e7345
HTTP: faster processing of asymmetric flows ( #2198 )
2023-12-11 14:52:31 +01:00
Ivan Nardi
adf8982d8e
fuzz: extend fuzzing coverage ( #2205 )
2023-12-11 12:48:50 +01:00
rl1987
59d476195c
Fix typos ( #2204 )
...
* Fix typo in ndpiSimpleIntegration.c
* Fix misspelling in a comment
2023-12-10 19:58:22 +01:00
Vladimir Gavrilov
c809e7c069
Replace complicated TPKT header validation with an helper function ( #2201 )
...
* Replace complicated TPKT header validation with an helper function
* Move tpkt_verify_hdr function definition to ndpi_utils.c
2023-12-10 12:10:50 +01:00
Ivan Nardi
f74cf16c36
OpenVPN: rework detection ( #2199 )
...
Close #1873
2023-12-06 10:24:26 +01:00
Vladimir Gavrilov
ad20846fad
Add Ether-S-Bus protocol dissector ( #2200 )
2023-12-05 17:20:38 +01:00
Vladimir Gavrilov
72601a69ff
Add some fast CRC16 algorithms implementation ( #2195 )
...
* Add some fast CRC16 algorithms implementation
* Update ndpi_crc.c
* Move crc16 stuff to ndpi_analyze.c
* IEEE C37.118: use new fast CRC-16/CCITT-FALSE implementation
2023-12-05 15:58:11 +01:00
Vladimir Gavrilov
be50493f44
Add IEEE C37.118 protocol dissector ( #2193 )
2023-12-05 08:06:15 +01:00
Ivan Nardi
7b0c16a70d
TLS: remove JA3+ fingerprints. ( #2192 )
...
See: #2191
2023-12-05 08:05:44 +01:00
Vladimir Gavrilov
c34bded4ef
Add ISO 9506-1 MMS protocol dissector ( #2189 )
...
* Add ISO 9506-1 MMS protocol dissector
* Fix detection on big-endian architectures
2023-12-01 09:03:07 +01:00
Ivan Nardi
983b8e8eee
STUN: parsing of DATA attribute ( #2179 )
2023-12-01 07:01:49 +01:00
Vladimir Gavrilov
24df1913ac
Add Beckhoff ADS protocol dissector ( #2181 )
...
* Add Beckhoff ADS protocol dissector
* Remove redundant le32toh
* Fix detection on big-endian architectures
2023-11-30 09:13:45 +01:00
Ivan Nardi
6f046df0dc
STUN: fix detection of DTLS ( #2187 )
...
Fix a memory leak
```
==97697==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x55a6967cfa7e in malloc (/home/ivan/svnrepos/nDPI/fuzz/fuzz_ndpi_reader+0x701a7e) (BuildId: c7124999fa1ccc54346fa7bd536d8eab88c3ea01)
#1 0x55a696972ab5 in ndpi_malloc /home/ivan/svnrepos/nDPI/src/lib/ndpi_memory.c:60:25
#2 0x55a696972da0 in ndpi_strdup /home/ivan/svnrepos/nDPI/src/lib/ndpi_memory.c:113:13
#3 0x55a696b7658d in processClientServerHello /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:2394:46
#4 0x55a696b86e81 in processTLSBlock /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:897:5
#5 0x55a696b80649 in ndpi_search_tls_udp /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:1262:11
#6 0x55a696b67a57 in ndpi_search_tls_wrapper /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:2751:5
#7 0x55a696b67758 in switch_to_tls /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:1408:3
#8 0x55a696c47810 in stun_search_again /home/ivan/svnrepos/nDPI/src/lib/protocols/stun.c:422:4
#9 0x55a6968a22af in ndpi_process_extra_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:7247:9
#10 0x55a6968acd6f in ndpi_internal_detection_process_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:7746:5
#11 0x55a6968aba3f in ndpi_detection_process_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:8013:22
#12 0x55a69683d30e in packet_processing /home/ivan/svnrepos/nDPI/fuzz/../example/reader_util.c:1723:31
#13 0x55a69683d30e in ndpi_workflow_process_packet /home/ivan/svnrepos/nDPI/fuzz/../example/reader_util.c:2440:10
#14 0x55a69680f08f in LLVMFuzzerTestOneInput /home/ivan/svnrepos/nDPI/fuzz/fuzz_ndpi_reader.c:135:7
[...]
SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s).
```
Found by oss-fuzzer
See: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64564
2023-11-30 09:09:40 +01:00
Ivan Nardi
d85f8592b8
Rework extraction of HTTP headers ( #2183 )
...
Extract only the headers that we really need/use.
Avoid too many `strcmp`; the algorithm might be a little bit
overwhelming right now but it might be useful if we have further headers
in the future.
2023-11-29 19:44:25 +01:00
Ivan Nardi
1100326edb
Fix FAQ ( #2186 )
2023-11-29 18:56:21 +01:00
Ivan Nardi
d3d9770b96
Update FAQ.md
2023-11-29 18:52:35 +01:00
Ivan Nardi
cc721fd3ce
Update FAQ.md
2023-11-29 18:28:26 +01:00
Ivan Nardi
0114992f5f
Add a FAQ for the project ( #2185 )
2023-11-29 18:25:36 +01:00
Ivan Nardi
3b35cb37d9
Keep separating public and private API ( #2157 )
...
See: b08c787fe
2023-11-29 17:13:00 +01:00
Ivan Nardi
ac90b1f009
Fix detection of NDPI_TCP_ISSUES flow risk ( #2177 )
...
We need to take into account retransmissions: they increase
`flow->all_packets_counter` counter but not `flows->packet_counter`
one.
Therefore, the right way to check for 3WH + RST pattern involves checking
for `flows->packet_counter == 0`
2023-11-29 16:55:39 +01:00
Toni
5fb631c8fe
Improved belgium gambling sites regex. ( #2184 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-11-29 16:15:23 +01:00
Vladimir Gavrilov
c60c03766c
Add Schneider Electric’s UMAS detection support ( #2180 )
...
* Add Schneider Electric’s UMAS detection support
* Swap proto IDs in ndpi_set_detected_protocol
* Update unit test result
2023-11-28 18:03:00 +01:00
Vladimir Gavrilov
688a197b85
Fix FINS false positives ( #2176 )
...
* Fix FINS false positives
* Add rsv (reserved) field check
2023-11-27 21:46:14 +01:00
Vladimir Gavrilov
ebb1bc2f34
Add Ether-S-I/O protocol dissector ( #2174 )
2023-11-27 19:04:05 +01:00
Vladimir Gavrilov
84427b0754
Add Omron FINS protocol dissector ( #2172 )
...
* Add Omron FINS protocol dissector
* Add a kludge to avoid invalid FINS over UDP detection as SkypeTeams and RTP
* Update unit test results
* Update protocols.rst
* Remove dummy flows from fins.pcap
2023-11-27 17:09:53 +01:00
3763c702f0
Rework S7Comm dissector; add S7Comm Plus support ( #2165 )
...
* Rework S7Comm dissector; add S7Comm Plus support
* Cleanup s7comm.c
* Improve S7Comm Plus detection
* s7comm/s7commplus: faster detection
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
Co-authored-by: Nardi Ivan <nardi.ivan@gmail.com >
2023-11-27 14:37:48 +01:00
Vladimir Gavrilov
0b6e261523
Improve CORBA detection ( #2167 )
...
* Improve CORBA detection
* Remove dummy flow from ziop.pcap
* Merge ziop.pcap and miop.pcap into corba.pcap
2023-11-27 13:10:50 +01:00
Vladimir Gavrilov
da629709f3
Add OPC UA protocol dissector ( #2169 )
2023-11-27 12:13:23 +01:00
Ivan Nardi
7ff22a7e3c
STUN: improve demultiplexing of DTLS packets ( #2153 )
...
Keep demultiplexing STUN/RTP/RTCP packets after DTLS ones.
We might end up processing the session a little longer, because we will
process the STUN/RTP/RTCP packets after the DTLS handshake.
2023-11-27 11:10:38 +01:00
Vladimir Gavrilov
87399b3544
Add RTPS protocol dissector ( #2168 )
2023-11-27 07:17:39 +01:00
Vladimir Gavrilov and 0xA50C1A1
27802b0134
Reduce false positives for H.323 over TCP ( #2164 )
...
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-23 17:29:00 +01:00
fbae51ae9d
Get rid of RDP false positives ( #2161 )
...
* Get rid of false positives in the RDP protocol dissector
* Remove kludge for RDP
* RDP: improve detection
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
Co-authored-by: Nardi Ivan <nardi.ivan@gmail.com >
2023-11-23 09:35:43 +01:00
Vladimir Gavrilov and 0xA50C1A1
5c8c5c90c2
Add HART-IP protocol dissector ( #2163 )
...
* Add HART-IP protocol dissector
* Update docs
* Update protocols.rst
* Reuse free proto id and re-run tests
* docs: move HART-IP to top of list
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-22 22:04:22 +01:00
Toni
21f2574033
Improved TFTP. Fixes #2075 . ( #2149 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2023-11-21 16:56:46 +01:00
Vladimir Gavrilov and 0xA50C1A1
35abafec4f
Get rid of Apache Cassandra false positives ( #2159 )
...
* Rewrite Apache Cassandra dissector
* Replace memcmp with strncmp
* Add payload length check
* Update Cassandra dissector
* Update test results
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-21 16:56:01 +01:00
Vladimir Gavrilov and 0xA50C1A1
ae6e6d61f0
Add IEEE 1588-2008 (PTPv2) dissector ( #2156 )
...
* Add IEEE 1588-2008 (PTPv2) dissector
PTPv2 is a time synchronization protocol in computer networks, similar to NTP.
* Add default protocol ports
* Update default test result for PTPv2
* Update copyright
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-21 13:39:54 +01:00
Ivan Nardi
55664392a9
Ip address list: aggregate Mullvad and Tor lists too ( #2154 )
...
Missing from bdb73db1a
See #2150
2023-11-21 08:28:32 +01:00
Vladimir Gavrilov and 0xA50C1A1
8d71998670
Remove Google+ support ( #2155 )
...
* Remove Google+ support
Google+ was discontiued in 2019, so I think that its protocol id can be freed for reuse.
* Fix typo
* Update tests
---------
Co-authored-by: 0xA50C1A1 <mage.wizard88@gmail.com >
2023-11-21 08:14:20 +01:00
Ivan Nardi
bdb73db1a4
IP lists: aggregate addresses wherever possible ( #2152 )
...
See #2150
2023-11-17 12:26:23 +01:00