Luca Deri
9f8c1e8630
BitTorrent detection improvements
2021-10-31 18:45:13 +01:00
Luca Deri
a9aa46287d
Little change in TLS debug traces
2021-10-28 10:16:33 +02:00
Luca Deri
a25d9d871e
Updated results
2021-10-27 23:04:29 +02:00
Luca Deri
5283755afa
Fixed TLS certificate dissection of subjectAltName
2021-10-27 22:51:59 +02:00
Luca Deri
aaa474a37d
Minor code cleanup
2021-10-27 09:32:11 +02:00
Ivan Nardi
6edb7bedd7
Avoid overwriting valid protocol in ndpi_detection_giveup ( #1360 )
...
We should avoid updating any valid protocol in `ndpi_detection_giveup`; we
should try to find a proper classification only if the flow is still
completely unclassified.
For example in the attached pcap there is a valid TLS session, recognized
as such by TLS dissector. However, the `ndpi_detection_giveup`function
updates it to "HTTP/TLS" (!?) simply because the server port is 80.
Note that the real issue is not the wrong classification, but the
wrong access to `flow->protos` union. If we already set some fields of
`flow->protos` and we change the protocol in `ndpi_detection_giveup`, we
might end up freeing some invalid pointers in `ndpi_free_flow_data`
(no wonder this issue has been found while fuzzing #1354 )
Fix GIT and TLS dissectors (issues found by CI fuzzer)
2021-10-27 09:23:07 +02:00
Toni
c4eebaaf5e
Serialize additional information stored in the flow struct. ( #1362 )
...
* Changed function signature of ndpi_flow2json (removed unused vlan_id; API break)
* Serialize NTP information.
* Improved QUIC serialization.
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-27 09:22:19 +02:00
Luca Deri
f41d8ac106
Improved STUN and RTP detection
2021-10-27 00:06:05 +02:00
Toni
41765efcf8
Detect invalid characters in text and set a risk. Fixes #1347 . ( #1363 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-26 21:34:01 +02:00
Luca Deri
5ccc61d1cb
Fixed Git protocol dissection ( #1355 )
2021-10-25 18:52:27 +02:00
Ivan Nardi
b6d9536533
Fixed cleartext protocol assignment ( #1357 )
2021-10-25 15:04:04 +02:00
Ivan Nardi
333a6d60e8
TLS: fix a heap-buffer-overflow ( #1356 )
...
Revert of c3d1c697
Error reproducible with the attached pcap and valgrind
2021-10-22 14:57:49 +02:00
Luca Deri
c3d1c69722
Fixed heap-buffer-overflow in TLS dissector
2021-10-20 22:07:47 +02:00
Ivan Nardi
8db8c8ae34
Fix QUIC log and remove SoulSeek leftovers after b97dc6ba ( #1351 )
...
Update .gitignore file
Fix a function prototype
Close #1349
2021-10-19 21:42:55 +02:00
Ivan Nardi
fea3991ad1
Fix some invalid memory reads ( #1350 )
...
`ndpi_detection_giveup()` (and any functions called by it) can't access
`ndpi_detection_module_struct->packet` anymore since 730c236 .
Sync unit tests results
Close #1348
2021-10-19 12:07:47 +02:00
Luca Deri
06f13fd2de
Added clertext alert with telnet
2021-10-19 08:44:29 +02:00
Toni
ed51987e3a
Fix broken fuzz_process_packet fuzzer by adding a call to ndpi_finalize_initialization(). ( #1334 )
...
* fixed several memory errors (heap-overflow, unitialized memory, etc)
* ability to build fuzz_process_packet with a main()
allowing to replay crash data generated with fuzz_process_packet
by LLVMs libfuzzer
* temporarily disable fuzzing if `tests/do.sh`
executed with env FUZZY_TESTING_ENABLED=1
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-18 23:16:32 +02:00
Luca Deri
7d3c3b23f8
Implemented RDP over UDP dissection
2021-10-18 22:12:28 +02:00
Luca Deri
9e97d20c25
Refreshed results list
2021-10-16 12:03:16 +02:00
Luca Deri
b08b6a6a28
Fixed cleartext protocol assignment
2021-10-16 12:02:04 +02:00
Luca Deri
c2e7fbce94
Updated test results after latest commit
2021-10-16 11:57:32 +02:00
Luca Deri
1b3c41a752
Reworked flow risks asignment
...
Added esceptions for windows update and binary application transfer risk
2021-10-16 11:55:08 +02:00
Luca Deri
b97dc6baa4
Removed outdated (and broken) soulseek dissector
2021-10-15 17:27:27 +02:00
Luca Deri
e696f31487
Updated test results
2021-10-14 22:18:34 +02:00
Luca Deri
b1a43cbcff
Added missing call to ndpi_reconcile_protocols() with protocol guess
2021-10-14 22:08:20 +02:00
Luca Deri
6e649e0cb6
Fixed issue on DGA numeric IP detection
2021-10-13 19:21:27 +02:00
Luca Deri
09668496c3
Indemt
2021-10-13 19:18:05 +02:00
Zied Aouini
a2e9730b23
Add issue templates. ( #1340 )
...
* Add issue template.
* Add config log instruction.
2021-10-13 18:39:10 +02:00
Luca Deri
937357e4bc
Implemented ndpi_ses_fitting() and ndpi_des_fitting()
...
for comuting the best alpha/beta values for exponential smoothing
2021-10-12 13:08:58 +02:00
Alfredo Cardigliano
d947437233
Return 0 on ndpi_init_serializer_ll success for consistency
2021-10-12 10:47:44 +00:00
Luca Deri
d13bc0e01a
Fixed DES initialisation
2021-10-12 12:38:40 +02:00
Ivan Nardi
550e6fe6fc
QUIC: fix an integer overflow ( #1337 )
...
Long standing bug: credits to @lnslbrty for digging into it and to
@aouinizied for the CI improvements
2021-10-11 23:08:10 +02:00
Toni
a8f938f7ac
Removed README.protocols because: ( #1333 )
...
* Tor via TLS should be detectable via DGA as a risk
* protocol limitations should be part of the official documentation in `doc/`
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-11 23:07:36 +02:00
Luca Deri
960e8ab22a
Win fix
2021-10-11 20:59:28 +02:00
Zied Aouini
ca827ae548
Fix FuzzCI. ( #1338 )
2021-10-11 20:17:12 +02:00
Zied Aouini
7e0724d576
Enable sanitizers on CIFuzz. ( #1336 )
2021-10-11 19:01:50 +02:00
Luca Deri
246d115d7b
Cleaned up code moving specific includes in files their are using it. Thi prevents ndpi_config.h to be included everywhere in apps using nDPI that might leade to #define redefinitions after the latest changes
2021-10-11 11:45:45 +02:00
Toni
60eca79fdf
Additional fix related to cf931fda6b. ( #1332 )
...
* configure.seed references removed
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-10 14:14:02 +02:00
Toni
549134ef10
Fix make dist and add it to the CI along with make -C doc text. Fixes #1324 ( #1327 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-10 13:15:38 +02:00
Toni
cf931fda6b
Get rid of configure.seed as it comes with some disadvantages. ( #1328 )
...
* using Autotools best-practices to achieve (hopefully) the same result
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-10 13:13:52 +02:00
Toni
6ff67b5043
Add more WindowsUpdate URLs as requested in #698 . ( #1329 )
...
Signed-off-by: Toni Uhlig <matzeton@googlemail.com >
2021-10-08 18:29:49 +02:00
Luca Deri
3ffb65a81c
Added extra check
2021-10-07 08:21:40 +02:00
Ivan Nardi
2dfc478ad4
Fix compilation with clang-13 or if some debug macros are enabled ( #1326 )
2021-10-06 18:32:15 +02:00
Luca Deri
944e8ed105
Added check
2021-10-06 18:28:09 +02:00
Luca Deri
2b4821a97b
Compilation fix for old Linux distributions
2021-10-06 09:28:04 +02:00
Luca Deri
d9c72999ee
Test update
2021-10-06 00:06:34 +02:00
Luca Deri
181a03c5ad
Compilation fix
2021-10-05 17:17:12 +02:00
Luca Deri
8957c52a48
Numeric IPs are not considered for DGA checks
2021-10-05 17:14:31 +02:00
Luca Deri
408d78e628
Improved DGA detection for skipping potential DGAs of known/popular domain names
2021-10-05 16:51:24 +02:00
Luca Deri
10576eab0a
TLS obsolete protocol is set when TLS < 1.2 (used to be 1.1)
2021-10-05 16:44:56 +02:00